Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Installation Guide #592

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Update Installation Guide #592

merged 2 commits into from
Mar 13, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Feb 27, 2024 •
edited
Loading

Closes #591

This updates the install instructions panel to only show three steps.

  • It updated the install instructions webview to the latest version
  • "Ask AppMap Navie AI" is checked if the users previously opened the Navie webview in the current project.
  • Notification "You opened your first AppMap" is updated to open Navie when the user clicks the action link of the Notification

(AFAIK this should not be merged indo develop at this time)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 27, 2024 •
edited
Loading

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

@jansorg jansorg force-pushed the install-guide-update branch 2 times, most recently from 0789909 to 6d6d97b Compare March 11, 2024 11:52
@jansorg jansorg marked this pull request as ready for review March 11, 2024 11:52
@jansorg jansorg force-pushed the install-guide-update branch from 6d6d97b to 364e566 Compare March 13, 2024 13:32
@jansorg jansorg requested a review from ahtrotta March 13, 2024 13:33
ahtrotta
ahtrotta approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ahtrotta ahtrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and worked well when I tested it, thanks!

@ahtrotta ahtrotta merged commit 56687a8 into develop Mar 13, 2024
6 checks passed
@ahtrotta ahtrotta deleted the install-guide-update branch March 13, 2024 18:41
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahtrotta ahtrotta ahtrotta approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instructions are updated to include Navie
3 participants
@jansorg @appland-release @ahtrotta