Handle show-appmap-tree event from Navie webview #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
|
jansorg
force-pushed
the
jansorg/show-appmap
branch
2 times, most recently
from
85623ee to
46fe245
Compare
|
@jansorg can you investigate the build failure? |
jansorg
force-pushed
the
jansorg/show-appmap
branch
from
46fe245 to
0b4cc2b
Compare
|
@ahtrotta I checked the log of Travis CI. It's a flaky test failure, but I couldn't understand how this could happen with our code. Rerunning Travis CI "fixed" it. |
ahtrotta
approved these changes
Mar 6, 2024
|
🎉 This PR is included in version 0.59.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #590
Opens the AppMap tool window and sets focus on the list of AppMaps.
The other panels of the tool window are collapsed.
Because the AppMap tree component is nested into several other components, the logic to make it visible and focused is iterating on the hierarchy.
The updated Navie webview contains links with
target=_blank. Previously, this opened an empty popup window inside the IDE. Now, these links are opened just like other external links.This change is applied to all our webviews.