Fix flaky Windows CI #594
Merged
Fix flaky Windows CI #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
⭐ New AppMaps[junit] Language resolver java project from [junit] Runtime analysis model authenticated without findings from |
jansorg
force-pushed
the
jansorg/windows-ci-fix
branch
from
e6b40a2 to
b0bc642
Compare
ahtrotta
approved these changes
Mar 1, 2024
This was referenced Mar 5, 2024
|
🎉 This PR is included in version 0.59.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes our flaky tests on the Windows runner of GitHub Actions.
The problem was an incorrect shutdown or the AppLand processes launched by tests. The first shutdown attempt cleared the processes and only waited for 1.0s, which isn't enough for slow Windows CI. The next shutdown attempts only got the empty list of processes and stopped early.
This PR updates the shutdown timeout to 10s and passes it into the service implementation handling the shutdown instead of attempting to be clever with several (incorrect) attempts.