Notify user if Navie isn't fully functional #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
⭐ New AppMaps[junit] Language resolver java project from [junit] Runtime analysis model authenticated without findings from ✖️ Removed AppMaps[junit] Default command line service directory tree watched subdir |
appland-release
pushed a commit
that referenced
this pull request
Mar 11, 2024
## [0.59.0](v0.58.0...v0.59.0) (2024-03-11) ### Features - notify user if Navie isn't fully functional ([#595](#595)) ([9b5f184]())- support to display the AppMap tool window from the Navie webview ([bb25a8b]())- Update install guide to include new node instructions ([d7815d7]()) ### Bug Fixes - compatibility with 2024.1 eap's backwards incompatible API of OAuthRequestHandlerBase ([5fc79c2]())- open external links with a target attribute like plain external links ([4494a4b]())- update actions to avoid exception "ActionUpdateThread.OLD_EDT is deprecated and going to be removed soon." with 2024.1 eap ([d6d18ca]())
|
🎉 This PR is included in version 0.59.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
apotterri
pushed a commit
that referenced
this pull request
Mar 25, 2024
## [0.59.0](v0.58.0...v0.59.0) (2024-03-11) ### Features - notify user if Navie isn't fully functional ([#595](#595)) ([9b5f184]())- support to display the AppMap tool window from the Navie webview ([bb25a8b]())- Update install guide to include new node instructions ([d7815d7]()) ### Bug Fixes - compatibility with 2024.1 eap's backwards incompatible API of OAuthRequestHandlerBase ([5fc79c2]())- open external links with a target attribute like plain external links ([4494a4b]())- update actions to avoid exception "ActionUpdateThread.OLD_EDT is deprecated and going to be removed soon." with 2024.1 eap ([d6d18ca]())
apotterri
pushed a commit
that referenced
this pull request
Mar 28, 2024
## [0.59.0](v0.58.0...v0.59.0) (2024-03-11) ### Features - notify user if Navie isn't fully functional ([#595](#595)) ([9b5f184]())- support to display the AppMap tool window from the Navie webview ([bb25a8b]())- Update install guide to include new node instructions ([d7815d7]()) ### Bug Fixes - compatibility with 2024.1 eap's backwards incompatible API of OAuthRequestHandlerBase ([5fc79c2]())- open external links with a target attribute like plain external links ([4494a4b]())- update actions to avoid exception "ActionUpdateThread.OLD_EDT is deprecated and going to be removed soon." with 2024.1 eap ([d6d18ca]())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #571
If the current IDE's webview JCEF isn't suitable for Navie, then show a notification to ask the user to update. If the user chose "don't show again", then the message is never shown again in any of the user's projects.
We're showing the message on top of the Navie editor tab, but because JCEF rendering is async the message is shown before the webview is fully visible.
If this is a problem, we could inject the message more deeply into the editor, e.g. when the webview's message that it's ready is received.