Fix compatibility with 2024.1 eap's backwards incompatible API of OAuthRequestHandlerBase #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthRequestHandlerBase
AppMap runtime code review
|
ahtrotta
approved these changes
Mar 6, 2024
|
🎉 This PR is included in version 0.59.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2024.1 is breaking the API we're using for "Sign in to AppMap" in an incompatible way. I've reported this at https://youtrack.jetbrains.com/issue/IDEA-346395, but so far JetBrains doesn't seem likely to fix this.
This PR is fixing the problem on our side to allow users of 2024.1 to sign in to AppMap.
This can be tested by using the "Sign in" action (at
Tools > AppMap) with the current 2024.1 eap of a JetBrains IDE. It should also be tested with 2022.1, our earliest supported version.I've successfully tested this with both versions.