Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new CI workflow to create webview pull requests #605

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Mar 11, 2024

Updates the new CI workflow added with #604 to only update one webview at a time and to use a unique branch per webview.

Dropping the two remaining "packageManager": "[email protected]" from package.json was necessary because NPM/node available with the ubuntu-latest runner was complaining about incompatible settings (see https://github.com/getappmap/appmap-intellij-plugin/actions/runs/8231132338/job/22505835614#step:5:7).

Sample pull request:

@jansorg jansorg force-pushed the jansorg/ci-update-changes branch from 8e56b6f to 9e314b8 Compare March 11, 2024 10:15
@jansorg jansorg changed the title Cix step to create a new PR Update new CI workflow to create webview pull requests Mar 11, 2024
@jansorg jansorg force-pushed the jansorg/ci-update-changes branch 3 times, most recently from c8a3568 to 8d4567a Compare March 11, 2024 10:28
@jansorg jansorg requested a review from ahtrotta March 11, 2024 10:30
Copy link

github-actions bot commented Mar 11, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

jansorg added 2 commits March 11, 2024 11:42
- include only update one webview at a time
- fix run name
- support signin webview
@jansorg jansorg force-pushed the jansorg/ci-update-changes branch from 8d4567a to e3c288e Compare March 11, 2024 10:43
@ahtrotta
Copy link
Contributor

@jansorg is this ready for review?

@jansorg
Copy link
Collaborator Author

jansorg commented Mar 11, 2024

@ahtrotta Sorry, the status was wrong.
Travis CI is failing because it's unable to download the JetBrains IDE packages, but it seems flaky and unrelated to this PR.

@ahtrotta ahtrotta merged commit da9d77c into develop Mar 18, 2024
5 of 6 checks passed
@ahtrotta ahtrotta deleted the jansorg/ci-update-changes branch March 18, 2024 16:55
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants