Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show notification if the download of an AppMap CLI binary failed #815

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Dec 9, 2024

Closes #814

Adds the notification.
It's only shown once after the download of a CLI binary failed.

Screenshot_20241209_153230

@jansorg jansorg requested a review from dustinbyrne December 9, 2024 14:36
Copy link

github-actions bot commented Dec 9, 2024

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

@kgilpin kgilpin force-pushed the jansorg/cli-download-notification branch from e261a1c to e78c5a7 Compare January 15, 2025 15:17
@kgilpin kgilpin added the enhancement New feature or request label Jan 15, 2025
@kgilpin kgilpin force-pushed the jansorg/cli-download-notification branch from c0433cc to db68b2f Compare January 15, 2025 17:23
@kgilpin kgilpin requested review from dustinbyrne and removed request for dustinbyrne January 15, 2025 21:49
@dustinbyrne dustinbyrne merged commit 64db02b into develop Jan 22, 2025
7 checks passed
@dustinbyrne dustinbyrne deleted the jansorg/cli-download-notification branch January 22, 2025 15:53
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.77.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users who cannot download the CLI binaries are directed to docs
4 participants