Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic finalization of streaming files to disk #78

Closed
2 tasks
dustinbyrne opened this issue Apr 28, 2021 · 2 comments · Fixed by #91
Closed
2 tasks

Atomic finalization of streaming files to disk #78

dustinbyrne opened this issue Apr 28, 2021 · 2 comments · Fixed by #91
Labels

Comments

@dustinbyrne
Copy link
Collaborator

dustinbyrne commented Apr 28, 2021

While streaming an AppMap to disk, the contents of the file should be written to a temporary file. Once the file has been finalized and closed, the temporary file is moved to its real destination.

  • Files in progress are written to ${filename}.appmap.json.partial
  • Once finalized, ${filename}.appmap.json.partial is moved to ${filename}.appmap.json
@kgilpin
Copy link
Contributor

kgilpin commented Apr 28, 2021 via email

@appland-release
Copy link

🎉 This issue has been resolved in version 1.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants