chore: Fix lint @typescript-eslint/no-inferrable-types

getappmap · Apr 21, 2024 · 071f870 · 071f870
1 parent 6984417
commit 071f870
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 14 deletions.
diff --git a/packages/cli/src/cmds/agentInstaller/commandRunner.ts b/packages/cli/src/cmds/agentInstaller/commandRunner.ts
@@ -6,7 +6,7 @@ import { verbose } from '../../utils';
 import { ChildProcessError } from '../errors';
 
 export class ProcessLog {
-  public static buffer: string = '';
+  public static buffer = '';
 
   public static log(command: string, childProcess: ChildProcess) {
     this.buffer = this.buffer.concat(`\n\nRunning command: \`${command}\`\n\n`);

diff --git a/packages/cli/src/cmds/agentInstaller/gradleParser.ts b/packages/cli/src/cmds/agentInstaller/gradleParser.ts
@@ -1,10 +1,10 @@
 import moo from 'moo';
 
 class SourceOffsets {
-  braceIdx: number = 1;
+  braceIdx = 1;
   // A syntactically correct build file will always have an rbrace to match the
   // lbrace.
-  rbrace: number = -1;
+  rbrace = -1;
   constructor(readonly blockName: string, readonly lbrace: number) {}
 }
 
@@ -45,7 +45,7 @@ export type GradleParseResult = {
 } & { [k in keyof Keywords]?: SourceOffsets };
 
 export class GradleParser {
-  public debug: number = 0;
+  public debug = 0;
 
   /**
    * Parse the given gradle source, returning a GradleParseResult describing what we found.

diff --git a/packages/cli/src/cmds/agentInstaller/pythonAgentInstaller.ts b/packages/cli/src/cmds/agentInstaller/pythonAgentInstaller.ts
@@ -152,7 +152,7 @@ export class PipenvInstaller extends PythonInstaller {
 
 export class PipInstaller extends PythonInstaller {
   static identifier = 'pip';
-  private _buildFile: string = 'requirements.txt';
+  private _buildFile = 'requirements.txt';
 
   constructor(path: string) {
     super(PipInstaller.identifier, path);

diff --git a/packages/cli/src/cmds/stats/stats.ts b/packages/cli/src/cmds/stats/stats.ts
@@ -75,7 +75,7 @@ export const builder = (args: yargs.Argv) => {
 
 export async function handler(
   argv: any,
-  handlerCaller: string = 'from_stats'
+  handlerCaller = 'from_stats'
 ): Promise<Array<EventInfo> | Promise<[SortedAppMapSize[], SlowestExecutionTime[]]> | undefined> {
   verbose(argv.verbose);
   handleWorkingDirectory(argv.directory);

diff --git a/packages/cli/src/cmds/stats/statsForDirectory.ts b/packages/cli/src/cmds/stats/statsForDirectory.ts
@@ -18,7 +18,7 @@ export async function statsForDirectory(
   appMapDir: string,
   format: string,
   limit: number,
-  handlerCaller: string = 'from_stats'
+  handlerCaller = 'from_stats'
 ): Promise<[SortedAppMapSize[], SlowestExecutionTime[]]> {
   async function calculateAppMapSizes(appMapDir: string): Promise<AppMapSizeTable> {
     const appMapSizes: AppMapSizeTable = {};

diff --git a/packages/cli/src/fingerprint/fingerprintDirectoryCommand.ts b/packages/cli/src/fingerprint/fingerprintDirectoryCommand.ts
@@ -4,8 +4,8 @@ import FingerprintQueue from './fingerprintQueue';
 import emitUsage from '../lib/emitUsage';
 
 class FingerprintDirectoryCommand {
-  private appmaps: number = 0;
-  private events: number = 0;
+  private appmaps = 0;
+  private events = 0;
   private metadata?: Metadata;
 
   constructor(private readonly directory: string) {}

diff --git a/packages/cli/src/lib/ticket/openTicket.ts b/packages/cli/src/lib/ticket/openTicket.ts
@@ -9,7 +9,7 @@ import { isValidEmail, isValidName } from './validation';
 export default async function openTicket(
   errors: string | string[],
   helpMsg: string = DEFAULT_HELP_MSG,
-  prompt: boolean = true
+  prompt = true
 ): Promise<void> {
   errors = !Array.isArray(errors) ? [errors] : errors;
 

diff --git a/packages/cli/src/rpc/explain/navie/navie-local.ts b/packages/cli/src/rpc/explain/navie/navie-local.ts
@@ -131,7 +131,7 @@ export default class LocalNavie extends EventEmitter implements INavie {
     this.emit('complete');
   }
 
-  #skipTelemetry: boolean = !Telemetry.enabled;
+  #skipTelemetry = !Telemetry.enabled;
 
   #reportConfigTelemetry() {
     if (this.#skipTelemetry) return;

diff --git a/packages/cli/tests/unit/agentInstall/agentInstaller.spec.ts b/packages/cli/tests/unit/agentInstall/agentInstaller.spec.ts
@@ -3,8 +3,8 @@ import AgentInstaller from '../../../src/cmds/agentInstaller/agentInstaller';
 import commandStruct from '../../../src/cmds/agentInstaller/commandStruct';
 
 class FakeInstaller extends AgentInstaller {
-  public buildFile: string = 'bf';
-  public documentation: string = 'http://www.example.com';
+  public buildFile = 'bf';
+  public documentation = 'http://www.example.com';
   constructor(path: string) {
     super('Fake', path);
   }

diff --git a/packages/cli/tests/unit/agentInstall/installCommand.spec.ts b/packages/cli/tests/unit/agentInstall/installCommand.spec.ts
@@ -36,6 +36,7 @@ const invokeCommand = (
     if (err) throw err;
   }
 ) => {
+  // eslint-disable-next-line @typescript-eslint/no-inferrable-types
   const debugSwitch: string = ''; // to debug, set debugSwitch to -v
 
   if (debugSwitch !== '-v') {

diff --git a/packages/cli/tests/unit/lib/openTicket.spec.ts b/packages/cli/tests/unit/lib/openTicket.spec.ts
@@ -18,7 +18,7 @@ const getNthCallArgs = (stub, nth) => (stub as sinon.SinonStub).getCall(nth).arg
 
 class TestErrorResponse implements HttpErrorResponse {
   headers: Record<string, string> = {};
-  body: string = '';
+  body = '';
   toString(): string {
     return `${JSON.stringify(this)}`;
   }