fix: Don't crash on an 'UNKNOWN: unknown error, lstat' error

getappmap · Dec 13, 2022 · a631928 · a631928
1 parent 534a7a7
commit a631928
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/cli/src/fingerprint/fingerprintWatchCommand.ts b/packages/cli/src/fingerprint/fingerprintWatchCommand.ts
@@ -52,6 +52,8 @@ export default class FingerprintWatchCommand {
       await this.watcher?.close();
       this.watcher = undefined;
       console.warn("File watching disabled.");
+    } else if (error.message.includes("UNKNOWN: unknown error, lstat")) {
+      console.warn(error.stack);
     } else {
       // let it crash if it's some other error, to learn what the error is
       throw error;

diff --git a/packages/cli/tests/unit/fingerprint/fingerprintWatchCommand.spec.ts b/packages/cli/tests/unit/fingerprint/fingerprintWatchCommand.spec.ts
@@ -93,6 +93,18 @@ describe(FingerprintWatchCommand, () => {
       expect(cmd.watcher).toBeUndefined();
      });
 
+     it('does not raise on unknown error lstat', async () => {
+      cmd = new FingerprintWatchCommand(appMapDir);
+      cmd.watcher = new FSWatcher();
+      expect(cmd.watcher).not.toBeUndefined();
+      console.warn = jest.fn();
+      const errorMessage = "UNKNOWN: unknown error, lstat";
+      await cmd.watcherErrorFunction(new Error(errorMessage));
+      expect(cmd.watcher).not.toBeUndefined();
+      expect(console.warn).toBeCalledTimes(1);
+      expect(console.warn).toHaveBeenCalledWith(expect.stringContaining(errorMessage));
+    });
+
     describe('telemetry', () => {
       let handler: Fingerprinter;