Lint TypeScript in packages/cli #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK; let's get Navie shipped otherwise this looks like merge conflict hell. |
dividedmind
force-pushed
the
chore/lint-typescript-in-cli
branch
2 times, most recently
from
ccbbfab to
be532f5
Compare
Otherwise the artifacts produced by the tests can clobber.
dividedmind
force-pushed
the
chore/lint-typescript-in-cli
branch
from
40c5850 to
7b04462
Compare
AppMap runtime code review
|
dustinbyrne
approved these changes
Apr 23, 2024
|
🎉 This PR is included in version @appland/appmap-v3.137.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we weren't linting .ts files in the CLI package.
I added the right configuration to enable this; also, removed the (quite obsolete) airbnb preset and replaced it with currently recommended ones.
I've fixed a couple low hanging lint problems and turned all the ones that are widespread in the package into warnings so they don't break the builds. We should strive to whittle down the list slowly.