feat: Navie welcome message UI #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinbyrne
force-pushed
the
feat/navie-welcome-message-ui
branch
3 times, most recently
from
67b4ef7 to
dd4a939
Compare
Defines new v2 RPC endpoints for metadata and welcome messages. v2.navie.metadata responds immediately so that the UI is not delayed. v2.navie.welcome detects the activity and builds suggested questions. It returns this data in a structured way so that the suggestions can be displayed as links or buttons in th eUI.
Adds a new version of the welcome message component that displays contextual activity information and structured suggestions. Separates static metadata from dynamic welcome content to improve load time.
dustinbyrne
force-pushed
the
feat/navie-welcome-message-ui
branch
from
dd4a939 to
ef08288
Compare
kgilpin
commented
Dec 18, 2024
| @@ -14,18 +14,23 @@ | |||
| </ul> | |||
| </div> | |||
| </div> | |||
| <div class="welcome-message-dynamic-placeholder" v-else>Analyzing workspace...</div> | |||
| <v-skeleton-loader class="welcome-message__loading" v-else /> | |||
There was a problem hiding this comment.
I noticed you dropped the cue "Analyzing workspace..."
There was a problem hiding this comment.
Typically this style of loading element does not include any text. Generally it only takes a few seconds to complete and reveal it's purpose.
kgilpin
commented
Dec 18, 2024
kgilpin
commented
Dec 18, 2024
kgilpin
commented
Dec 18, 2024
|
|
||
| Questions should try not to reference "changes", instead reference the specific concepts or symbols from the diff. | ||
| Suggestions should try not to reference "changes", instead reference the specific concepts or symbols from the diff. | ||
|
|
There was a problem hiding this comment.
In a next step, it would be interesting to see if Navie is able to determine when the user might want to create or run test cases to reproduce the issue.
kgilpin
commented
Dec 18, 2024
dustinbyrne
force-pushed
the
feat/navie-welcome-message-ui
branch
from
ef08288 to
4a71c22
Compare
dustinbyrne
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version @appland/navie-v1.38.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new version of the welcome message UI that provides a more structured and context-aware experience. The key changes include:
The new UI shows a standard greeting header followed by either:
Resolves #2155
Resolves #2148