fix: Subscription indicators are now behind a feature flag #2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flag is provided via prop to `ChatSearch`, a boolean value named `displaySubscription`. It is defaulted to false.
kgilpin
approved these changes
Jan 8, 2025
The former is no longer maintained.
It's failing CI due to Chrome sandboxing issues and it's not worth any more time trying to debug this.
dustinbyrne
force-pushed
the
fix/feature-flag-subscriptions
branch
from
6ff09a2 to
3a0b77b
Compare
|
🎉 This PR is included in version @appland/appmap-v3.181.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a feature flag to control the display of subscription-related indicators within the Navie chat.
Details:
displaySubscriptionhas been introduced across relevant components. This flag defaults tofalseand is configurable via props.ChatSearch,ChatInput, andLlmConfigurationhave been updated to conditionally render subscription indicators based on thedisplaySubscriptionflag.displaySubscriptionflag is toggled.