fix: Disable file watching on "ENOSPC: System limit for number of file watchers reached" error #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symwell
force-pushed
the
sw/disable_watching_on_ENOSPC_error
branch
6 times, most recently
from
2d657c4 to
844c2ef
Compare
symwell
force-pushed
the
sw/disable_watching_on_ENOSPC_error
branch
4 times, most recently
from
ebbed03 to
47f5e4e
Compare
symwell
force-pushed
the
sw/disable_watching_on_ENOSPC_error
branch
2 times, most recently
from
79b5dd3 to
9e6032a
Compare
file watchers reached" error is raised.
symwell
force-pushed
the
sw/disable_watching_on_ENOSPC_error
branch
from
9e6032a to
87b0a34
Compare
ahtrotta
suggested changes
Dec 12, 2022
…umber of file watchers reached" error is raised. fix: Address feedback from code review
ahtrotta
approved these changes
Dec 13, 2022
|
🎉 This PR is included in version @appland/appmap-v3.53.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the indexer processes an appmap_dir that has more files than the OS limit for watching files, FSWatch raises an ENOSPC error. Catch this specific type of ENOSPC error and disable file watching. File changes continue to be detected through file polling.
Output of manual test. After disabling file watching, file polling continues to run.
Fixes #894
If the reason for watching too many files was that the directory monitored wasn't precisely the
appmap_dirbut something more general, like.monitoring two parent directories up, then saving theappmap_dirinappmap.ymlthrough this pr may be enough to make this ENOSPC error disappear without this fix.This fix should still be applied because choosing to discard error messages instead of crash is still needed, as shown in #898