Skip to content
This repository has been archived by the owner on Nov 6, 2022. It is now read-only.

Version bump 1.5.2 #488

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Version bump 1.5.2 #488

merged 1 commit into from
Dec 2, 2019

Conversation

lukecarbis
Copy link
Member

Some small tweaks to the Block Importer and onboarding dialogs.

  • New: Selective import now allows you to choose which of the blocks contained in your export file you'd like to import
  • Fix: Onboarding notices are fixed so that they show in the right places, and at the right times

Copy link
Collaborator

@kienstra kienstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Hi @lukecarbis,
This looks good. It increments the version in the same places as other version bump PRs.

I added a suggested line to the Changelog, feel free modify or ignore it 😄

This review doesn't include a smoke testing of the plugin. I'll do that a little, also.


* New: Selective import now allows you to choose which of the blocks contained in your export file you'd like to import
* Fix: Onboarding notices are fixed so that they show in the right places, and at the right times

Copy link
Collaborator

@kienstra kienstra Dec 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like:

New: For scalability, limit the amount of Block Lab blocks that can be added via the 'Content Blocks' UI to 100. There's no limit to the blocks that can be added via the PHP API.

@kienstra
Copy link
Collaborator

kienstra commented Dec 2, 2019

Here's the diff to the last release, 1.5.1.

The main non-test files changed are class-loader.php and class-onboarding.php. We probably don't need a huge regression testing.

@lukecarbis lukecarbis merged commit e4f5b80 into develop Dec 2, 2019
@lukecarbis lukecarbis deleted the version-bump-to-1.5.2 branch December 2, 2019 01:52
@kienstra kienstra mentioned this pull request Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants