providing client-side function with current frames number and predicted number #111
Conversation
There was a problem hiding this comment.
One concern I have about this direction is that when you predict it has a bunch of side effects and cleaning those up is going to be messy. How about something like passing a predicate that ScanBase implements, subclasses can override, and nullifies a prediction before it has any side effects in Ocr.swift?
CardScan/Classes/Ocr.swift
Outdated
| @@ -60,8 +60,8 @@ public class Ocr { | |||
| } | |||
|
|
|||
| @available(iOS 11.2, *) | |||
| public func performWithErrorCorrection(for croppedCardImage: CGImage, squareCardImage: CGImage, fullCardImage: CGImage) -> (String?, Expiry?, Bool, Bool) { | |||
| let number = self.perform(croppedCardImage: croppedCardImage, squareCardImage: squareCardImage, fullCardImage: fullCardImage) | |||
| public func performWithErrorCorrection(for croppedCardImage: CGImage, squareCardImage: CGImage, fullCardImage: CGImage, predictedNumberPredicate: (String?, String) -> Bool ) -> (String?, Expiry?, Bool, Bool) { | |||
There was a problem hiding this comment.
Can you look at if it's possible to have a default parameter for the predictedNumbersPredicate, something like { _, _ in true}
I don't know if this is possible with Swift or if there are any subtleties, so we should be thorough if we do go down this route
CardScan/Classes/Ocr.swift
Outdated
| @@ -90,9 +90,17 @@ public class Ocr { | |||
| } | |||
|
|
|||
| @available(iOS 11.2, *) | |||
| public func perform(croppedCardImage: CGImage, squareCardImage: CGImage?, fullCardImage: CGImage?) -> String? { | |||
| public func perform(croppedCardImage: CGImage, squareCardImage: CGImage?, fullCardImage: CGImage?, predictedNumberPredicate: (String? , String) -> Bool ) -> String? { | |||
There was a problem hiding this comment.
same here for default value
| @@ -304,6 +304,12 @@ import UIKit | |||
| } | |||
| } | |||
|
|
|||
| public override func usePredictedCardNumber(predictedNumber: String?, currentFrameNumber: String) -> Bool { | |||
| print("predicted number: \(predictedNumber)") | |||
There was a problem hiding this comment.
can you remove these print statements?
| @@ -304,6 +304,12 @@ import UIKit | |||
| } | |||
| } | |||
|
|
|||
| public override func usePredictedCardNumber(predictedNumber: String?, currentFrameNumber: String) -> Bool { | |||
There was a problem hiding this comment.
maybe change the name to useCurrentFrameNumber since I think that the predictedNumber here is the error corrected number
| @@ -304,6 +304,10 @@ import UIKit | |||
| } | |||
| } | |||
|
|
|||
| public override func useCurrentFrameNumber(predictedNumber: String?, currentFrameNumber: String) -> Bool { | |||
There was a problem hiding this comment.
can you change predictedNumber to errorCorrectedNumber to make the distinction more clear (the current frame number is also predicted).
CardScan/Classes/Ocr.swift
Outdated
| @@ -60,8 +60,8 @@ public class Ocr { | |||
| } | |||
|
|
|||
| @available(iOS 11.2, *) | |||
| public func performWithErrorCorrection(for croppedCardImage: CGImage, squareCardImage: CGImage, fullCardImage: CGImage) -> (String?, Expiry?, Bool, Bool) { | |||
| let number = self.perform(croppedCardImage: croppedCardImage, squareCardImage: squareCardImage, fullCardImage: fullCardImage) | |||
| public func performWithErrorCorrection(for croppedCardImage: CGImage, squareCardImage: CGImage, fullCardImage: CGImage, predictedNumberPredicate: (String?, String) -> Bool = { _,_ in true } ) -> (String?, Expiry?, Bool, Bool) { | |||
There was a problem hiding this comment.
instead of predictedNumberPredicate how about useCurrentFrameNumber?
jaimejiyepark
changed the title
OCR'sperformWithErrorCorrection()uponPredictedCardNumber()allows clients to handle the case where the predicted number and expected number do not align with their own implementation