Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding CardScan pod scheme for carthage build #120

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Conversation

jaimejiyepark
Copy link
Collaborator

@jaimejiyepark jaimejiyepark commented Feb 4, 2020

CardScan scheme in Pods was not clicked as shared so this PR is to share it for carthage build

@jaimejiyepark jaimejiyepark requested a review from kingst February 6, 2020 19:47
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test it and how do we avoid this type of regression again in the future

@jaimejiyepark
Copy link
Collaborator Author

jaimejiyepark commented Feb 6, 2020

I tested it manually: Tried to build carthage, didn't build, checked the schemes, noticed that CardScan in Pods wasn't clicked, selected it, rebuilt, and kapow carthage built.

I think this happens so often because we make changes to project.pbxproj, the various info.plists, etc when we change the schemes which allows carthage to build. but we also almost by instinct do not commit those files. So I guess I'll be more diligent and committing those files when carthage doesnt build.

@jaimejiyepark jaimejiyepark merged commit bae7f3a into master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants