Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying gitignore and adding back pod shared xcsheme to allow carthage build #128

Merged
merged 4 commits into from
Feb 13, 2020

Conversation

jaimejiyepark
Copy link
Collaborator

@jaimejiyepark jaimejiyepark commented Feb 12, 2020

  • gitignore inside Example folder did not negate Pods.xcodeproj and Target Support Files/CardScan/ to be ignored because of the Pods/ pattern matching.
    Look at the row where it says "logs/ !logs/important.log"

  • CardScan.xscheme added back to Pods/Pods.xcdeproj/xcshareddata, the directory where Carthage looks for shared frameworks.

@jaimejiyepark jaimejiyepark requested a review from kingst February 12, 2020 23:34
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaimejiyepark jaimejiyepark changed the title Modifying gitignore to allow carthage build Modifying gitignore and adding back pod shared xcsheme to allow carthage build Feb 13, 2020
@jaimejiyepark jaimejiyepark merged commit edab63b into master Feb 13, 2020
@jaimejiyepark jaimejiyepark deleted the carthage_build branch February 13, 2020 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants