Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix landscape / portrait mode bug #138

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Fix landscape / portrait mode bug #138

merged 2 commits into from
Mar 10, 2020

Conversation

jaimejiyepark
Copy link
Collaborator

No description provided.

@jaimejiyepark jaimejiyepark changed the title landscape changes Fix landscape / portrait mode bug Mar 10, 2020
@jaimejiyepark jaimejiyepark requested a review from kingst March 10, 2020 18:08
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks pretty good, I'm going to test it out on my iPad before I approve it. Can you update the README as well to let people know about changes to their AppDelegate?

@jaimejiyepark
Copy link
Collaborator Author

yes i will change the README and how do I let people know?

Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out on my iPad and it's working well. Nice job! #shipit

@jaimejiyepark
Copy link
Collaborator Author

sweeeeet! ill commit the README.md changes then merge.

@jaimejiyepark jaimejiyepark merged commit a37ec48 into master Mar 10, 2020
@jaimejiyepark jaimejiyepark deleted the landscape_portrait branch March 10, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants