Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the OcrMainLoop variables as public #156

Merged
merged 1 commit into from
May 5, 2020
Merged

Expose the OcrMainLoop variables as public #156

merged 1 commit into from
May 5, 2020

Conversation

kingst
Copy link
Collaborator

@kingst kingst commented May 5, 2020

Also includes changes to related objects around the OcrMainLoop and gets rid of blockingPush from the API. If one wants to do a blockingPush they should do it themselves on top of our API.

@kingst kingst requested a review from jaimejiyepark May 5, 2020 22:21
kingst
kingst commented May 5, 2020
View reviewed changes
Copy link
Collaborator Author

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review for experimental branch

@kingst kingst merged commit c073603 into master May 5, 2020
@kingst kingst deleted the remove_blocking_push branch May 5, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaimejiyepark jaimejiyepark Awaiting requested review from jaimejiyepark jaimejiyepark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kingst