Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote full screen & ROI image cropping, grey box image function #162

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Rewrote full screen & ROI image cropping, grey box image function #162

merged 1 commit into from
Jun 5, 2020

Conversation

jaimejiyepark
Copy link
Collaborator

No description provided.

@jaimejiyepark jaimejiyepark changed the title full screen image cropping + draw grey Rewrote full screen & ROI image cropping, grey box image function Jun 3, 2020
@jaimejiyepark jaimejiyepark requested a review from kingst June 3, 2020 19:29
kingst
kingst approved these changes Jun 5, 2020
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR #shipit

I'll test on my devices but will coordinate via slack

@jaimejiyepark jaimejiyepark merged commit 066bdd7 into master Jun 5, 2020
@jaimejiyepark jaimejiyepark deleted the image_cropping branch June 5, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingst kingst kingst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimejiyepark @kingst