Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a SimpleScanViewController for full UI customization #188

Merged
merged 4 commits into from
Jul 25, 2020

Conversation

kingst
Copy link
Collaborator

@kingst kingst commented Jul 25, 2020

This PR is for our programmatic UI extension to ScanBaseViewController. We'll use this to show how people can fully customize our UI. This new class is meant to be complete but bare bones from a UI perspective. People can use it directly if they like the look and feel, or the can modify variables or subclass for more control.

In a future PR we'll:

  • Add examples to show simple UI customizations.
  • Migrate our fraud ViewControllers over to use this.
  • Migrate ScanViewController over to use this as a base class.

@kingst kingst requested a review from jaimejiyepark July 25, 2020 17:42
@jaimejiyepark
Copy link
Collaborator

looks good. one thing though: is it a good idea to have another scan delegate protocol for simple that looks exactly like the original? or should we make the scanVC protocol more generic to accommodate simple

@kingst
Copy link
Collaborator Author

kingst commented Jul 25, 2020

It's a good question and my first cut did this but I created a separate protocol for two reasons (1) I don't want to change public interfaces unless we get a massive simplification, which isn't there case here and (2) we're going to use this as the base for fraud challenges which don't need skip, so the interface isn't a good match

@jaimejiyepark
Copy link
Collaborator

hmm alright then. something to keep in mind. #shipit

@kingst kingst merged commit c142954 into master Jul 25, 2020
@kingst kingst deleted the simple_scan_viewcontroller branch July 25, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants