Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make model download function public #201

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Make model download function public #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CardScan/Classes/API.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public struct Api {
apiCall(endpoint: endpoint, parameters: apiParameters, completion: completion)
}

static func modelDownload(signedUrl: String, completion: @escaping ApiCompletion) {
static public func donwloadLatestModel(signedUrl: String, completion: @escaping ApiCompletion) {
guard let url = URL(string: signedUrl) else {
DispatchQueue.main.async { completion(nil, apiUrlNotSet) }
return
Expand All @@ -153,16 +153,16 @@ public struct Api {
}.resume()
}

static public func getModelDownloadConfig(endpoint: String, parameters: [String: Any], completion: @escaping ApiCompletion) {
static public func getLatestModelConfig(endpoint: String, parameters: [String: Any], completion: @escaping ApiCompletion) {
if baseUrl == nil || apiKey == nil {
DispatchQueue.main.async { completion(nil, apiUrlNotSet) }
return
}

modelDownloadConfig(endpoint: endpoint, parameters: parameters, completion: completion)
downloadLatestModelConfig(endpoint: endpoint, parameters: parameters, completion: completion)
}

private static func modelDownloadConfig(endpoint: String, parameters: [String: Any], completion: @escaping ApiCompletion) {
private static func downloadLatestModelConfig(endpoint: String, parameters: [String: Any], completion: @escaping ApiCompletion) {
guard let baseUrl = self.baseUrl else {
DispatchQueue.main.async { completion(nil, apiUrlNotSet) }
return
Expand Down