Download and compile model function fix #208
Conversation
jaimejiyepark
requested review from
awushensky,
dxaen,
kingst and
xsl
as code owners
| DispatchQueue.main.async { | ||
| completion(["mlmodel_url": location], nil) | ||
| completion(["compiled_model_url": compiledUrl], nil) |
There was a problem hiding this comment.
will changing this break any existing code? I couldn't find anything referencing this string, is it used anywhere?
There was a problem hiding this comment.
this function is used in model updates in cardverify
There was a problem hiding this comment.
Got it, so there will be a corresponding change in CardVerify here? makes sense, although this is breaking. Do we have any way of indicating which versions of CardVerify are compatible with which versions of CardScan?
There was a problem hiding this comment.
yes that is correct. We indicate compatibility in the cardverify podspec file, where cardverify's version dependency of cardscan is stated.
|
i can use an |
|
@jaimejiyepark In this case, let's skip it. For future changes that introduce new APIs that are not ready for public consumption, let's mark them as |
the downloaded task's temporary location gets emptied when the completion handler completes so the ml model compiling has to be done in the same function.