Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for zero fraud #235

Merged
merged 2 commits into from
Dec 1, 2020
Merged

Prep for zero fraud #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2c7515
Tinkering with zero fraud
kingst Nov 24, 2020
0923d28
Make sure that programmatic UI buttons animate
kingst Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CardScan/Classes/ScanViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ import UIKit
@objc public var expiryYear: String?
@objc public var name: String?
@objc public var image: UIImage?
@objc public var cvv: String?
@objc public var postalCode: String?

public init(number: String) {
self.number = number
Expand Down
8 changes: 4 additions & 4 deletions CardScan/Classes/SimpleScanViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,10 @@ open class SimpleScanViewController: ScanBaseViewController {

// our UI components
public var descriptionText = UILabel()
public var closeButton = UIButton()
public var torchButton = UIButton()
public var closeButton = UIButton(type: .system)
public var torchButton = UIButton(type: .system)
private var debugView: UIImageView?
public var enableCameraPermissionsButton = UIButton()
public var enableCameraPermissionsButton = UIButton(type: .system)
public var enableCameraPermissionsText = UILabel()

// Dynamic card details
Expand Down Expand Up @@ -358,7 +358,7 @@ open class SimpleScanViewController: ScanBaseViewController {
showScannedCardDetails(prediction: prediction)
}

override public func onCameraPermissionDenied(showedPrompt: Bool) {
override open func onCameraPermissionDenied(showedPrompt: Bool) {
descriptionText.isHidden = true
torchButton.isHidden = true

Expand Down