Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new model inits #28

Merged
merged 1 commit into from
Jun 27, 2019
Merged

Integrate new model inits #28

merged 1 commit into from
Jun 27, 2019

Conversation

jaimejiyepark
Copy link
Collaborator

changed bundleURL func name
deleted convenience inits
changed old model inits to new ones

kingst
kingst reviewed Jun 27, 2019
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the code looks clean. I'll test this branch locally before I approve but looks good. Nice job!

kingst
kingst approved these changes Jun 27, 2019
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my phone and it worked for me. #shipit

@kingst kingst merged commit d53dadb into master Jun 27, 2019
@kingst kingst deleted the change_old_bundle_to_new branch June 27, 2019 18:01
@kingst kingst mentioned this pull request Jul 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingst kingst kingst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimejiyepark @kingst