Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test for model/bundle loading #30

Merged
merged 2 commits into from
Jun 28, 2019
Merged

unit test for model/bundle loading #30

merged 2 commits into from
Jun 28, 2019

Conversation

jaimejiyepark
Copy link
Collaborator

Test_Bundle.swift

  • pulled allll the little local variables out and created them into a member of this class to examine if the guard statements work.
  • I initialized them all to nil and compiled (a boolean to see if the model will compile) to false to compare the before and after when calling these guard statements.
  • the func compiled_model also sets all the member variables and is used to compare to the individual setting functions

Test_Case

  • Every test begins with an empty bundle and a filled bundle (filled with compiled_model). The empty objects are tested in the beginning to see if they're truly empty, if they're still empty with an improperly set, if the tested property is filled, and if it matches the filled bundle's property.

@jaimejiyepark jaimejiyepark requested a review from kingst June 28, 2019 20:47
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#shipit, love seeing some more unit tests

@kingst kingst merged commit a228ad1 into master Jun 28, 2019
@kingst kingst deleted the bundle_unit_test branch July 5, 2019 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants