Added ability to run ScanViewController with custom images #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,10 @@ import Vision | |||
| @objc func skipButton() -> String | |||
| } | |||
|
|
|||
| @objc public protocol TestingImageDataSource { | |||
There was a problem hiding this comment.
Can you give me an example of how this protocol will be used? I read below that it can be used for custom testing but I am still unclear on how it it should be implemented.
There was a problem hiding this comment.
Yeah, checkout Example/CardScan/ViewController.swift, which is part of this PR. It shows how to implement this protocol and how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will help us with automated testing by adding two new capabilities:
TestingImageDataSourceshowTestingImageViewWith these changes in place, app builders can test this library if they run automated tests on real hardware. The reason this only works with real hardware is because of the way Apple handles camera emulation in their simulators (ie they don't).