Drop iPhone 6 and older using a device blacklist #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the image showing iPhone 6 failing (correctly) and everything else working |
|
tested, great, amazing as always. #shipit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPU on iPhone 6 and iPhone 6 Plus are too slow to support our machine learning models efficiently, so we're dropping them from our supported hardware. We should also investigate iPad and iPod touch later, but for now this is good enough.
I tested this using our Firebase TestLab setup and confirmed that iPhone6 is not supported but all newer devices are.
https://console.firebase.google.com/project/bouncer-card-scan/testlab/histories/bh.1247d8283144895c/matrices/6344922426939065259