Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mini bug @ viewwillappear #54

Merged
merged 2 commits into from
Aug 8, 2019
Merged

mini bug @ viewwillappear #54

merged 2 commits into from
Aug 8, 2019

Conversation

jaimejiyepark
Copy link
Collaborator

the && in viewwillappear logic prevent the ocr data to be reset on the events where the expirations arent detected properly.

@jaimejiyepark jaimejiyepark requested a review from kingst August 8, 2019 21:38
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#shipit, looks good to me

@kingst kingst merged commit 3006618 into master Aug 8, 2019
@kingst kingst deleted the fix_viewwillappear branch August 8, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants