Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In prep for the new model #92

Merged
merged 3 commits into from
Oct 30, 2019
Merged

In prep for the new model #92

merged 3 commits into from
Oct 30, 2019

Conversation

dxaen
Copy link
Member

@dxaen dxaen commented Oct 30, 2019

Made a few changes to the overall organization, moved constants around to places where they make the most sense. Add some more documentation to methods.

Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's just some refactoring -- no logic change. LGTM, #shipit

@dxaen
Copy link
Member Author

dxaen commented Oct 30, 2019

I can't merge it.

@dxaen dxaen merged commit bad1702 into master Oct 30, 2019
@kingst kingst deleted the new_model branch March 5, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants