Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

created public interface to get/set torch levels #97

Merged
merged 3 commits into from
Nov 21, 2019
Merged

created public interface to get/set torch levels #97

merged 3 commits into from
Nov 21, 2019

Conversation

jaimejiyepark
Copy link
Collaborator

  • Exposes torch state and torch availability through function calls
  • Modify torch level intensity through initial ScanViewController set up or through function setTorchLevel
  • If no torch level is set, then it is defaulted to 1.0

@jaimejiyepark jaimejiyepark requested a review from kingst November 20, 2019 23:55
kingst
kingst reviewed Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this so quickly, amazing! Left a few comments...

CardScan/Classes/Torch.swift Outdated Show resolved Hide resolved
CardScan/Classes/Torch.swift Outdated Show resolved Hide resolved
CardScan/Classes/VideoFeed.swift Outdated Show resolved Hide resolved
CardScan/Classes/VideoFeed.swift Outdated Show resolved Hide resolved
kingst
kingst reviewed Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Responded to your comments

kingst
kingst approved these changes Nov 21, 2019
View reviewed changes
Copy link
Collaborator

@kingst kingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but feel free to merge it after you address the comment

CardScan/Classes/VideoFeed.swift Outdated Show resolved Hide resolved
@jaimejiyepark jaimejiyepark merged commit b2d0c52 into master Nov 21, 2019
@jaimejiyepark jaimejiyepark deleted the torch_changes branch November 21, 2019 18:22
@jaimejiyepark jaimejiyepark changed the title exposing torch functions created public interface to get/set torch levels Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingst kingst kingst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaimejiyepark @kingst