-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create workflow actions for automated releasing #86
Conversation
try create release workflow action publish and snapshots pipelines trigger on push for testing
Sorry if this is a silly question as I'm not that familiar with GHA. Can anyone with a GH account run the GHA, or do we need to setup permissions so that only certain people/level of access can publish? |
I think we should add either a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scripts look good to me, just left 2 comments.
At the moment, anyone with write access to the repo can publish a release which will trigger the release action. Seemed like a sensible default option.
Great idea - I'll write it up this morning. Can draft it in notion then either move to the repo or keep there. |
I documented everything - the process and the scripts. |
@zmarkan Thanks for documenting! I think that is the right place to leave those docs given this is a public repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I think the current permissions are fine, but we can revisit later if anyone wants something different.
Notion doc is a good place too.
Nice! |
So do we just merge now it's been approved? Or is there a step in the flow that I'm missing? |
Yes you can merge! |
New release and snapshots actions for automated publishing to Maven Central. Fulfills https://github.com/getditto/DittoAndroidTools/issues/80
Release workflow triggers on new release publish in GitHub - all projects with the same version deployed at the same time - so we can keep consistency. Signing is automated, using GitHub's secrets.
Snapshots workflow currently doesn't work but would ideally trigger nightly. Leaving the script in there to eventually debug & fix.
Let me know if it makes sense - happy to walk you folks through it & answer any Qs.
And most importantly thanks Raj for your help looking at error logs!!!