Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: Use proper fn pointers for C# headers #167

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Experiment: Use proper fn pointers for C# headers #167

wants to merge 2 commits into from

Conversation

danielhenrymantilla
Copy link
Collaborator

@danielhenrymantilla danielhenrymantilla self-assigned this Jun 13, 2023
hamchapman
hamchapman approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@hamchapman hamchapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And that diff is delightful to see 👌

@danielhenrymantilla
Copy link
Collaborator Author

Note that this is a breaking change, supported .NET version-wise, so for safer-ffi to feature it it may be prudent to release it as 0.2.0, and for our repo to use it we'll have to wait for when @phatblat is given the time to tackle this in https://github.com/getditto/ditto/pull/8940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamchapman hamchapman hamchapman approved these changes

@phatblat phatblat phatblat approved these changes

Assignees

@danielhenrymantilla danielhenrymantilla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielhenrymantilla @phatblat @hamchapman