Skip to content

Commit

Permalink
Fix flaky tests
Browse files Browse the repository at this point in the history
  • Loading branch information
shashwatahalder01 committed Dec 11, 2024
1 parent a1044c9 commit 18731e2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/pw/pages/privacyPolicyPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export class PrivacyPolicyPage extends CustomerPage {
// contact vendor
async contactVendor(storeName: string, storeContactData: storeContactData) {
await this.toPass(async () => {
await this.gotoUntilNetworkidle(data.subUrls.frontend.vendorDetails(helpers.slugify(storeName)));
await this.gotoUntilNetworkidle(data.subUrls.frontend.vendorDetails(helpers.slugify(storeName)), { waitUntil: 'networkidle' }, true);
await this.toBeVisible(singleStoreCustomer.storeContactForm.storeContactForm);
});
await this.clearAndType(singleStoreCustomer.storeContactForm.name, storeContactData.name);
Expand Down
2 changes: 1 addition & 1 deletion tests/pw/tests/e2e/catalogmode.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ test.describe('Catalog mode test', () => {

apiUtils = new ApiUtils(await request.newContext());

[, sellerId, , vendorName] = await apiUtils.createStore(payloads.createStore(), payloads.adminAuth); // todo: add catalog settings
[, sellerId, , vendorName] = await apiUtils.createStore(payloads.createStore(), payloads.adminAuth);

const vendorContext = await browser.newContext(data.header.userAuth(vendorName));
vPage = await vendorContext.newPage();
Expand Down

0 comments on commit 18731e2

Please sign in to comment.