🪓 fix: Prevented store URL generation for staff managers on admin dashboard #2505
Conversation
devAsadNur
added
Needs: Testing
WalkthroughThe pull request modifies the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
includes/Admin/UserProfile.php (1)
Line range hint
89-95: Optimize string formatting using printf.Replace
echo sprintf()withprintf()to improve code efficiency and address the pipeline failure.- echo sprintf( + printf( /* translators: %1$s: banner width, %2$s: banner height in integers */ esc_attr__( 'Upload a banner for your store. Banner size is (%1$sx%2$s) pixels.', 'dokan-lite' ), esc_attr( $banner_width ), esc_attr( $banner_height ) );🧰 Tools
🪛 GitHub Actions: Inspections
[error] Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.
🧹 Nitpick comments (1)
includes/Admin/UserProfile.php (1)
Line range hint
385-516: Consider architectural improvements for better maintainability and security.
- Move the inline JavaScript to a separate file and enqueue it properly using WordPress's
wp_enqueue_script().- Add additional security checks for file uploads, including file type validation.
- Consider implementing rate limiting for the AJAX URL validation endpoint.
Example of moving the JavaScript to a separate file:
+ // In a new file: assets/js/admin-user-profile.js + (function($) { + var Dokan_Settings = { + // ... existing JavaScript code ... + }; + $(document).ready(function() { + Dokan_Settings.init(); + // ... rest of the JavaScript code ... + }); + })(jQuery); - <script type="text/javascript"> - jQuery(function($){ - // ... existing JavaScript code ... - }); - </script>Then enqueue it in the
enqueue_scriptsmethod:wp_enqueue_script( 'dokan-admin-user-profile', DOKAN_PLUGIN_ASSEST . '/js/admin-user-profile.js', array('jquery'), DOKAN_PLUGIN_VERSION, true );🧰 Tools
🪛 GitHub Actions: Inspections
[error] Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
includes/Admin/UserProfile.php(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Inspections
includes/Admin/UserProfile.php
[error] Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: e2e tests (3, 3)
- GitHub Check: e2e tests (2, 3)
- GitHub Check: api tests (1, 1)
- GitHub Check: e2e tests (1, 3)
🔇 Additional comments (1)
includes/Admin/UserProfile.php (1)
137-145: LGTM! Clean implementation of the staff manager restriction.The conditional check effectively prevents store URL generation for staff managers while maintaining proper escaping and following WordPress coding standards.
🧰 Tools
🪛 GitHub Actions: Inspections
[error] Unnecessary "echo sprintf(...)" found. Use "printf(...)" instead.
| <?php if ( ! user_can( $user, 'vendor_staff' ) ) : ?> | ||
| <tr> | ||
| <th><?php esc_html_e( 'Store URL', 'dokan-lite' ); ?></th> | ||
| <td> | ||
| <input type="text" name="dokan_store_url" data-vendor="<?php echo esc_attr( $user->ID ); ?>" class="regular-text" id="seller-url" value="<?php echo esc_attr( $user->data->user_nicename ); ?>"><strong id="url-alart-mgs"></strong> | ||
| <p><small><?php echo esc_url( home_url() . '/' . dokan_get_option( 'custom_store_url', 'dokan_general', 'store' ) ); ?>/<strong id="url-alart"><?php echo esc_attr( $user->data->user_nicename ); ?></strong></small></p> | ||
| </td> | ||
| </tr> | ||
| <?php endif; ?> |
There was a problem hiding this comment.
Pls remove the if condition and generate the url for vendor using dokan_get_current_user_id()
$vendor = new WP_User( dokan_get_current_user_id() );Now use
$vendorinstead of$userto generate the URL.
mrabbani
added
Needs: Author Reply
and removed
Needs: Dev Review
All Submissions:
Changes proposed in this Pull Request:
Related Pull Request(s)
Closes
How to test the changes in this Pull Request:
Changelog entry
fix: Prevented store URL generation for staff managers on admin dashboard
Detailed Description of the pull request. What was previous behaviour
and what will be changed in this PR.
Before Changes
Describe the issue before changes with screenshots(s).
After Changes
Describe the issue after changes with screenshot(s).
Feature Video (optional)
Link of detailed video if this PR is for a feature.
PR Self Review Checklist:
FOR PR REVIEWER ONLY:
Summary by CodeRabbit