Segment additions. #528
Merged
Segment additions. #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.props.dispatch({type: 'ADD_METRICS', items: spaceUpdates.newMetrics, newGuesstimates: spaceUpdates.newGuesstimates}) | ||
| this.props.dispatch(spaceActions.updateGraph(this._id())) | ||
| this.props.dispatch(simulationActions.runSimulations(this._id(), spaceUpdates.newMetrics)) | ||
| if (!_.isEmpty(spaceUpdates.newMetrics)) { |
There was a problem hiding this comment.
is this supposed to be part of it?
There was a problem hiding this comment.
Yes; if you put an empty JSON object into the Import SLURP window, we don't want to run any of these dispatches. Just a tiny fix I noticed while adding the segment stuff and figured it wasn't worth another PR. Next time I'll be more clear in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tracks various data about user interactions with the canvas. Also minor fix for import slurp.