Fix replication bug #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one fix for the following bug. It seems like there were a few problems here:
I'm not sure exactly what caused these, but the reducers definitely shouldn't have allowed for this to create gigantic models of the same metrics and guesstimates. I've solved the main issue here by enforcing uniqueness for metrics and guesstimates within models. Later on we could look at the other two issues directly (this may take some time to reproduce).
Also, this is not a fix for the fact that some metrics are so huge that they won't actually get loaded. Ideally there would be a back end fix for this; we would have a script to go through every single item and fix it. This will take some work, so I'll get to this later on.
#85