Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update Gamedig #3841

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

teooko
Copy link
Contributor

@teooko teooko commented Aug 11, 2024

Proposed change

I upgraded the gamedig library to version 5.1.1 and enabled the checkOldIDs option to ensure that requests using old game IDs are still processed correctly. I verified that it functions correctly with both old and new IDs.

Type of change

  • New service widget
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation only
  • Other (please explain)

Checklist:

  • If applicable, I have added corresponding documentation changes.
  • If applicable, I have reviewed the feature and / or service widget guidelines.
  • I have checked that all code style checks pass using pre-commit hooks and linting checks.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.

@shamoon shamoon changed the title Feature/gamedig arguments Chore: update Gamedig Aug 11, 2024
@shamoon shamoon enabled auto-merge (squash) August 11, 2024 18:32
auto-merge was automatically disabled August 11, 2024 18:59

Head branch was pushed to by a user without write access

@shamoon shamoon enabled auto-merge (squash) August 11, 2024 21:55
Copy link
Collaborator

@shamoon shamoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the package for npm and pnpm

@shamoon shamoon merged commit 884ee62 into gethomepage:main Aug 12, 2024
2 checks passed
shamoon added a commit that referenced this pull request Aug 12, 2024
Plancke pushed a commit to Plancke/homepage that referenced this pull request Sep 6, 2024
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants