HTTP-42 Add support for Batch request submission in HTTP Sink. #58

kristoffSC · 2023-06-15T11:50:31Z

Description

This PR adds support for submitting events by HTTP Sink in batch mode, meaning that body of one HTTP PUT/POST requests will contain data for many processed events.

The data is represented as Json array, like so:

[
  {
    "id": 1,
    "first_name": "Ninette",
    "last_name": "Clee",
    "gender": "Female",
    "stock": "CDZI",
    "currency": "RUB",
    "tx_date": "2021-08-24 15:22:59"
  },
  {
    "id": 2,
    "first_name": "Rob",
    "last_name": "Zombie",
    "gender": "Male",
    "stock": "DGICA",
    "currency": "GBP",
    "tx_date": "2021-10-25 20:53:54"
  },
  {
    "id": 3,
    "first_name": "Adam",
    "last_name": "Jones",
    "gender": "Male",
    "stock": "DGICA",
    "currency": "PLN",
    "tx_date": "2021-10-26 20:53:54"
  }
]

This is a breaking change. Users will have to adapt to it or restore "single mode" by setting:
gid.connector.http.sink.writer.request.mode = single

Resolves #42

PR Checklist

Tests added
Changelog updated

…TP sink. Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-06-15T11:53:37Z

File	Coverage [97.87%]	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestSubmitter.java	95%	🍏

Total Project Coverage	93.68%	🍏

…TP sink #2 Signed-off-by: Krzysztof Chmielewski <[email protected]>

…TP sink #3 Signed-off-by: Krzysztof Chmielewski <[email protected]>

…TP sink #4 Signed-off-by: Krzysztof Chmielewski <[email protected]>

…TP sink #5 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

…TP sink #6 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

…TP sink #7 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-06-29T16:21:07Z

File	Coverage [89.64%]	🍏
SinkRequestSubmitMode.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
BatchRequestSubmitter.java	94.29%	🍏
PerRequestSubmitter.java	93.33%	🍏
HttpSinkInternal.java	75.52%	🍏
BatchRequestSubmitterFactory.java	50%	❌

Total Project Coverage	93.19%	🍏

github-actions · 2023-06-29T23:06:03Z

File	Coverage [93.44%]	🍏
SinkRequestSubmitMode.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
BatchRequestSubmitter.java	93.78%	🍏
PerRequestSubmitter.java	93.41%	🍏
HttpSinkInternal.java	75.52%	🍏

Total Project Coverage	93.83%	🍏

…TP sink #8 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-06-29T23:13:04Z

File	Coverage [93.44%]	🍏
SinkRequestSubmitMode.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
BatchRequestSubmitter.java	93.78%	🍏
PerRequestSubmitter.java	93.41%	🍏
HttpSinkInternal.java	75.52%	🍏

Total Project Coverage	93.83%	🍏

…TP sink #9 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-06-30T10:35:11Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

github-actions · 2023-06-30T10:35:33Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

github-actions · 2023-06-30T12:20:58Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

…TP - doc. Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-06-30T12:28:10Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

kristoffSC · 2023-07-02T15:16:49Z

...in/java/com/getindata/connectors/http/internal/sink/httpclient/AbstractRequestSubmitter.java

+import com.getindata.connectors.http.internal.config.HttpConnectorConfigConstants;
+import com.getindata.connectors.http.internal.utils.ThreadUtils;
+
+public abstract class AbstractRequestSubmitter implements RequestSubmitter {


This is base class for PerReqeust and Batch submitter implementations.

kristoffSC · 2023-07-02T15:17:35Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

+import com.getindata.connectors.http.internal.sink.HttpSinkRequestEntry;
+
+@Slf4j
+public class BatchRequestSubmitter extends AbstractRequestSubmitter {


New thing - core logic for submitting requests as Json array in batch in one HTTP query.

kristoffSC · 2023-07-02T15:19:46Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/JavaNetSinkHttpClient.java


-        this.httpClient = JavaNetHttpClientFactory.createClient(properties, httpClientExecutor);
        this.httpPostRequestCallback = httpPostRequestCallback;


refactoring moved to BatchRequestSubmitterFactory and SingleRequestSubmitterFactory

kristoffSC · 2023-07-02T15:20:28Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/JavaNetSinkHttpClient.java

-                    publishingThreadPool
-                );
-            responseFutures.add(response);
-        }


Logic for PerReqeust submmission - moved to PerRequestSubbitter class

kristoffSC · 2023-07-02T15:22:11Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/PerRequestSubmitter.java

+import com.getindata.connectors.http.internal.sink.HttpSinkRequestEntry;
+
+@Slf4j
+public class PerRequestSubmitter extends AbstractRequestSubmitter {


New class containing old logic from JavaNetSinkHttpClient - this is the original PerReqeust submission.

…TP sink #9 Java doc Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-07-02T20:17:34Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

swtwsk

Typos and a small incrementation bug.

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

swtwsk · 2023-07-03T09:05:17Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

+            if (!previousReqeustMethod.equalsIgnoreCase(entry.method)) {
+                // break batch and submit
+                responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
+                reqeustBatch.clear();
+                // start a new batch for new HTTP method.
+                reqeustBatch.add(entry);
+            } else {
+                reqeustBatch.add(entry);
+                if (++counter % httpReqeustBatchSize == 0) {
+                    // batch is full, submit and start new batch.
+                    responseFutures.add(sendBatch(endpointUrl, reqeustBatch));
+                    reqeustBatch.clear();
+                }
+            }


I think it could be simplified a bit:

Suggested change

if (!previousReqeustMethod.equalsIgnoreCase(entry.method)) {

// break batch and submit

responseFutures.add(sendBatch(endpointUrl, reqeustBatch));

reqeustBatch.clear();

// start a new batch for new HTTP method.

reqeustBatch.add(entry);

} else {

reqeustBatch.add(entry);

if (++counter % httpReqeustBatchSize == 0) {

// batch is full, submit and start new batch.

responseFutures.add(sendBatch(endpointUrl, reqeustBatch));

reqeustBatch.clear();

}

}

if (!previousReqeustMethod.equalsIgnoreCase(entry.method) || counter % httpReqeustBatchSize == 0) {

// break batch and submit

responseFutures.add(sendBatch(endpointUrl, reqeustBatch));

reqeustBatch.clear();

} else {

reqeustBatch.add(entry);

counter++;

}

Of course, it would mean that we will be sending the batch one iteration step later, but it should not be a problem anyway.

And btw, what's about counter? Wouldn't requestBatch.size() >= httpRequestBatchSize be sufficient? And, also, current version of the code has a small bug — counter is incremented only in the else branch, however in the if we're calling requestBatch.add(entry) too.

changed, please let me know wht do you think now.

...ain/java/com/getindata/connectors/http/internal/table/sink/Slf4jHttpPostRequestCallback.java

…TP sink #10 - changes after Code review - fix typos Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-07-03T11:19:34Z

File	Coverage [94.58%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	94.02%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.85%	🍏

github-actions · 2023-07-03T12:21:05Z

File	Coverage [94.5%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	93.46%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.83%	🍏

swtwsk

Mostly LGTM. There's still some typos to fix. And a question about sending empty request — feel free to fix that or keep, your call.

swtwsk · 2023-07-04T09:36:09Z

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

+        String previousReqeustMethod = requestsToSubmit.get(0).method;
+        List<HttpSinkRequestEntry> reqeustBatch = new ArrayList<>(httpRequestBatchSize);


still typos 😅

src/main/java/com/getindata/connectors/http/internal/sink/httpclient/BatchRequestSubmitter.java

github-actions · 2023-07-04T09:56:08Z

File	Coverage [94.5%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	93.46%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.83%	🍏

…TP sink #10 - changes after Code review - fix batch split Signed-off-by: Krzysztof Chmielewski <[email protected]>

github-actions · 2023-07-04T10:10:10Z

File	Coverage [94.5%]	🍏
SinkRequestSubmitMode.java	100%	🍏
HttpSink.java	100%	🍏
HttpSinkBuilder.java	100%	🍏
JavaNetHttpResponseWrapper.java	100%	🍏
AbstractRequestSubmitter.java	100%	🍏
BatchRequestSubmitterFactory.java	100%	🍏
JavaNetSinkHttpClient.java	100%	🍏
PerRequestRequestSubmitterFactory.java	100%	🍏
HttpDynamicTableSinkFactory.java	100%	🍏
HttpDynamicSink.java	95.58%	🍏
JavaNetHttpClientFactory.java	95.35%	🍏
PerRequestSubmitter.java	94.12%	🍏
BatchRequestSubmitter.java	93.46%	🍏
HttpSinkInternal.java	75.52%	🍏
Slf4jHttpPostRequestCallbackFactory.java	52.94%	❌

Total Project Coverage	93.83%	🍏

HTTP-42-BatchRequest - add support for batch request processing in HT…

189a7c0

…TP sink. Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC added the enhancement New feature or request label Jun 15, 2023

kristoffSC self-assigned this Jun 15, 2023

kristoffSC added 2 commits June 16, 2023 23:43

HTTP-42-BatchRequest - add support for batch request processing in HT…

2dd1135

…TP sink #2 Signed-off-by: Krzysztof Chmielewski <[email protected]>

HTTP-42-BatchRequest - add support for batch request processing in HT…

8c314fe

…TP sink #3 Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch 2 times, most recently from 9467a83 to 01bb95d Compare June 20, 2023 21:32

HTTP-42-BatchRequest - add support for batch request processing in HT…

627b54a

…TP sink #4 Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 01bb95d to 627b54a Compare June 20, 2023 21:38

HTTP-42-BatchRequest - add support for batch request processing in HT…

b327c31

…TP sink #5 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 148d155 to b327c31 Compare June 22, 2023 19:32

HTTP-42-BatchRequest - add support for batch request processing in HT…

ea9fff3

…TP sink #6 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 35c9a16 to ea9fff3 Compare June 27, 2023 12:45

HTTP-42-BatchRequest - add support for batch request processing in HT…

b78ff43

…TP sink #7 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

HTTP-42-BatchRequest - add support for batch request processing in HT…

bbcb439

…TP sink #8 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 7a865ea to bbcb439 Compare June 29, 2023 23:09

HTTP-42-BatchRequest - add support for batch request processing in HT…

26db840

…TP sink #9 tests Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 8996221 to 26db840 Compare June 30, 2023 10:31

HTTP-42-BatchRequest - add support for batch request processing in HT…

2f4b615

…TP - doc. Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 6a60321 to 2f4b615 Compare June 30, 2023 12:24

kristoffSC requested a review from swtwsk June 30, 2023 12:24

kristoffSC changed the title ~~[Draft]HTTP-42-BatchRequest~~ HTTP-42-BatchRequest Jun 30, 2023

kristoffSC changed the title ~~HTTP-42-BatchRequest~~ HTTP-42 Add support for Batch request submission in HTTP Sink. Jun 30, 2023

kristoffSC marked this pull request as ready for review June 30, 2023 12:25

kristoffSC requested a review from grzegorz8 June 30, 2023 12:25

kristoffSC commented Jul 2, 2023

View reviewed changes

HTTP-42-BatchRequest - add support for batch request processing in HT…

c92a6e2

…TP sink #9 Java doc Signed-off-by: Krzysztof Chmielewski <[email protected]>

swtwsk suggested changes Jul 3, 2023

View reviewed changes

HTTP-42-BatchRequest - add support for batch request processing in HT…

6d7de3e

…TP sink #10 - changes after Code review - fix typos Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC requested a review from swtwsk July 3, 2023 12:18

kristoffSC mentioned this pull request Jul 3, 2023

Adding Support for "x-www-form-urlencoded" Format in Connector #59

Open

swtwsk approved these changes Jul 4, 2023

View reviewed changes

kristoffSC force-pushed the HTTP-42-BatchRequest branch from 224a164 to ad9d58f Compare July 4, 2023 09:51

HTTP-42-BatchRequest - add support for batch request processing in HT…

4797cbf

…TP sink #10 - changes after Code review - fix batch split Signed-off-by: Krzysztof Chmielewski <[email protected]>

kristoffSC force-pushed the HTTP-42-BatchRequest branch from ad9d58f to 4797cbf Compare July 4, 2023 10:06

kristoffSC merged commit 9b94c92 into main Jul 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTTP-42 Add support for Batch request submission in HTTP Sink. #58

HTTP-42 Add support for Batch request submission in HTTP Sink. #58

kristoffSC commented Jun 15, 2023 •

edited

Loading

github-actions bot commented Jun 15, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

kristoffSC Jul 2, 2023

kristoffSC Jul 2, 2023

kristoffSC Jul 2, 2023

kristoffSC Jul 2, 2023

kristoffSC Jul 2, 2023 •

edited

Loading

github-actions bot commented Jul 2, 2023

swtwsk left a comment

swtwsk Jul 3, 2023

kristoffSC Jul 3, 2023

kristoffSC Jul 3, 2023

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

swtwsk left a comment

swtwsk Jul 4, 2023

github-actions bot commented Jul 4, 2023

github-actions bot commented Jul 4, 2023


		this.httpClient = JavaNetHttpClientFactory.createClient(properties, httpClientExecutor);
		this.httpPostRequestCallback = httpPostRequestCallback;

		String previousReqeustMethod = requestsToSubmit.get(0).method;
		List<HttpSinkRequestEntry> reqeustBatch = new ArrayList<>(httpRequestBatchSize);

HTTP-42 Add support for Batch request submission in HTTP Sink. #58

HTTP-42 Add support for Batch request submission in HTTP Sink. #58

Conversation

kristoffSC commented Jun 15, 2023 • edited Loading

Description

PR Checklist

github-actions bot commented Jun 15, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 29, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

github-actions bot commented Jun 30, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kristoffSC Jul 2, 2023 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2023

swtwsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 3, 2023

github-actions bot commented Jul 3, 2023

swtwsk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 4, 2023

github-actions bot commented Jul 4, 2023

kristoffSC commented Jun 15, 2023 •

edited

Loading

kristoffSC Jul 2, 2023 •

edited

Loading