Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
User::roles()
has a new optional$purpose
parameter to pass a user action (create
orchange
). If one is passed, the roles collection is filtered via$roles->canBeChanged()
/$roles->canBeCreated()
which checks if the current user has the permissions to apply the action to each role.::roles()
doesn't return only the current role for non-admin users but all available rolesReasoning
Available roles depend on the context as they depend on whether the current user has permissions to e.g. create a user with a certain role or change the role to a certain role.
Additional context
We need to pass the
$purpose
parameters, e.g. in user dialogs, in a subsequent PR.Ready?