Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only record analytics session once and record start and end closes #3089 #3090

Merged
merged 4 commits into from
Oct 9, 2015

Conversation

myleshorton
Copy link
Contributor

No description provided.

@myleshorton
Copy link
Contributor Author

I think we can combine this with your changes @atavism (at least I don't think our different implementations will hurt each other even if they're slightly redundant). You mind taking a look at this one?

@lixiaodongsql
Copy link

Hello, I am a Lantern user in China. Thank you very much for developing Lantern software to help Chinese netizens circumvent China's firewall. I really appreciate it.

After I just installed Lantern 2.0.2 software in my system, Lantern 2.0.2 couldn't work in my network environment. But after a while Lantern 2.0.2 can work in my network environment. I upload the Lantern 2.0.2 log file to Google Group Lantern Developers.
https://groups.google.com/forum/#!topic/lantern-devel/z2dNnebcvjM
Above is the URL of the topic which I posted in Google Group Lantern Developers.
Could you please help me find out what caused Lantern 2.0.2 not to work at the very beginning? Thank you very much for your help. I really appreciate it.
At first I downloaded file update_windows_386.bz2 from the URL https://s3.amazonaws.com/github-cloud/releases/1380117/d6eaa40e-5167-11e5-8c90-a3f1f172d785.bz2?response-content-disposition=attachment%3B%20filename%3Dupdate_windows_386.bz2&response-content-type=application/octet-stream&AWSAccessKeyId=AKIAISTNZFOVBIJMK3TQ&Expires=1441246557&Signature=bcS61htEnOF0ngCs4saWGwWKZu4%3D

I put the suffix ".exe" behind the original file name "update_windows_386" in order to make the file become an executable file. After I double-clicked the executable file, the only one " Lantern.exe " thread appeared in my Windows Task Manager. But the only one " Lantern.exe " thread immediately disappeared from my Windows Task Manager after the only one " Lantern.exe " thread appeared in my Windows Task Manager. I use Windows XP Service Pack 3.
I know from another Google Group that some other Lantern users in China also find that the newest version Lantern software can't run in Windows XP Service Pack 3 System.

https://groups.google.com/forum/#!topic/fqlt/Ca3xJm3_1JU
Could you please help me solve this problem in next version of Lantern software? Thank you so much for your help again. I really appreciate it.

@uaalto
Copy link
Contributor

uaalto commented Sep 3, 2015

Hi @lixiaodongsql. Your problem is probably unrelated to this PR. The possible issues are: https://github.com/getlantern/lantern/issues/3077 and https://github.com/getlantern/lantern/issues/3086. The fixes are almost done and will be ready in the next release. Thank you!

@myleshorton
Copy link
Contributor Author

OK now just the cloudfront distribution test failure remains -- merging.

myleshorton added a commit that referenced this pull request Oct 9, 2015
Only record analytics session once and record start and end closes #3089
@myleshorton myleshorton merged commit a611575 into valencia Oct 9, 2015
@myleshorton myleshorton deleted the issue3089 branch October 9, 2015 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants