Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Theme problem: toggleTheme() doesn't change the setting in ADMIN, and reader page always uses dark background #155

Closed
somebelly opened this issue Jan 29, 2021 · 2 comments · Fixed by #156
Closed

[Bug Report] Theme problem: toggleTheme() doesn't change the setting in ADMIN, and reader page always uses dark background #155

somebelly opened this issue Jan 29, 2021 · 2 comments · Fixed by #156
Labels
bug Something isn't working

Comments

@somebelly
Copy link

Describe the bug
2 issues:

  • when using toggleTheme() in navbar, the setting in ADMIN doesn't change.
  • reader page always uses dark background even when using light theme.

To Reproduce
See the video below.

Expected behavior

  • when using toggleTheme() in navbar, the setting in ADMIN changes.
  • the background of the reader page changes according to the theme.

Environment (please complete the following information):

  • OS: KDE neon User Edition 5.20 (Ubuntu 20.04)
  • Browser: Chromium 88.0.4324.96 (Official Build) snap (64-bit)
  • Mango Version: v0.19.1 (binary release)
out.mp4
@somebelly somebelly added the bug Something isn't working label Jan 29, 2021
@somebelly somebelly changed the title [Bug Report] Theme problem: toggleTheme() doesn't change the setting in ADMIN, and reader page always uses dark background [Bug Report] Theme problem: toggleTheme() doesn't change the setting in ADMIN, and reader page always uses dark background Jan 29, 2021
@hkalexling
Copy link
Member

Hi, thanks for reaching out!

when using toggleTheme() in navbar, the setting in ADMIN doesn't change.

This is indeed a bug. I will fix it in the next release. Thanks for the bug report!

reader page always uses dark background even when using light theme.

This is intentional. IMHO the light manga pages don't look good on a white background, so the reader page background is always black, regardless of your theme setting.

hkalexling added a commit that referenced this issue Jan 29, 2021
@hkalexling
Fix admin page theme setting syncing (#155)
1fad530
@hkalexling hkalexling mentioned this issue Jan 29, 2021
Merged
@hkalexling
Copy link
Member

This is now fixed in v0.20.0. Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.20.0 getmango/Mango
2 participants
@hkalexling @somebelly