Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Continue Reading on Home showing incorrect entries based on progress: 0 entries in info.json (v0.7.2) #83

Closed
jaredlt opened this issue Jul 1, 2020 · 2 comments
Closed

[Bug Report] Continue Reading on Home showing incorrect entries based on progress: 0 entries in info.json (v0.7.2) #83

jaredlt opened this issue Jul 1, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@jaredlt
Copy link
Collaborator

jaredlt commented Jul 1, 2020

Describe the bug

Continue Reading section on Home page shows incorrect entries if you have manually marked an entry as unread.

To Reproduce

  • For a title you have not started (have not read any entries)
  • Mark an entry as read
  • Mark that same entry as unread

Expected behavior

Title should not show in Continue Reading section on Home page.
@jaredlt jaredlt added the bug Something isn't working label Jul 1, 2020
@hkalexling
Copy link
Member

Ah you are right! Here we only check whether the progress field exists. We should only return it if the progress value is not zero. I will fix this in the next release. Thanks for the heads up!

hkalexling added a commit that referenced this issue Jul 3, 2020
@hkalexling
Only show started entries in "continue reading"
f6c3935 
(#83)
@hkalexling
Copy link
Member

Fixed in v0.7.3. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hkalexling @jaredlt