-
-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP cache for thumbnails, pages, dimensions #214
Conversation
Get image data and use it for hashing
Use zip_path and mtime for hashing It used for weak validation
Should I use browser cache, too?
the above response header makes images cached into a memory or a disk. |
Thanks a lot for the PR! I took a quick look and it looks good. Let me spend more time and test it tomorrow :) |
Regarding the |
okay! I'll add |
d815346
to
4a261d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Use
ETag
header for HTTP caching