Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dir.contents_signature to detect valid image files #315

Merged
merged 4 commits into from
Jul 3, 2022
Merged

Fix Dir.contents_signature to detect valid image files #315

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbc0c2c
Fix Dir.contents_signature to detect valid image files added
Leeingnyo Jun 18, 2022
17a9c8e
pass lint
Leeingnyo Jun 18, 2022
19a8f31
Merge branch 'dev' into fix/rescan-when-files-added
hkalexling Jun 26, 2022
2d2486a
Merge branch 'dev' into fix/rescan-when-files-added
hkalexling Jul 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/util/signature.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,12 @@ class Dir
path = File.join dirname, fn
if File.directory? path
signatures << Dir.contents_signature path, cache
signatures << fn if DirEntry.is_valid? path
else
# Only add its signature value to `signatures` when it is a
# supported file
signatures << fn if ArchiveEntry.is_valid? fn
if ArchiveEntry.is_valid?(fn) || is_supported_image_file(fn)
signatures << fn
end
end
Fiber.yield
end
Expand Down