ECR: add CreateRepository name validation (#6479)

getmoto · Jul 4, 2023 · 4011a68 · 4011a68
1 parent b662727
commit 4011a68
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/moto/ecr/models.py b/moto/ecr/models.py
@@ -30,6 +30,9 @@
 from moto.utilities.tagging_service import TaggingService
 
 ECR_REPOSITORY_ARN_PATTERN = "^arn:(?P<partition>[^:]+):ecr:(?P<region>[^:]+):(?P<account_id>[^:]+):repository/(?P<repo_name>.*)$"
+ECR_REPOSITORY_NAME_PATTERN = (
+    "(?:[a-z0-9]+(?:[._-][a-z0-9]+)*/)*[a-z0-9]+(?:[._-][a-z0-9]+)*"
+)
 
 EcrRepositoryArn = namedtuple(
     "EcrRepositoryArn", ["partition", "region", "account_id", "repo_name"]
@@ -466,6 +469,12 @@ def create_repository(
         if self.repositories.get(repository_name):
             raise RepositoryAlreadyExistsException(repository_name, self.account_id)
 
+        match = re.fullmatch(ECR_REPOSITORY_NAME_PATTERN, repository_name)
+        if not match:
+            raise InvalidParameterException(
+                f"Invalid parameter at 'repositoryName' failed to satisfy constraint: 'must satisfy regular expression '{ECR_REPOSITORY_NAME_PATTERN}'"
+            )
+
         repository = Repository(
             account_id=self.account_id,
             region_name=self.region_name,

diff --git a/tests/test_ecr/test_ecr_boto3.py b/tests/test_ecr/test_ecr_boto3.py
@@ -156,6 +156,19 @@ def test_create_repository_error_already_exists():
     )
 
 
+@mock_ecr
+def test_create_repository_error_name_validation():
+    client = boto3.client("ecr", region_name="eu-central-1")
+    repo_name = "tesT"
+
+    with pytest.raises(ClientError) as e:
+        client.create_repository(repositoryName=repo_name)
+
+    ex = e.value
+    ex.operation_name.should.equal("CreateRepository")
+    ex.response["Error"]["Code"].should.contain("InvalidParameterException")
+
+
 @mock_ecr
 def test_describe_repositories():
     client = boto3.client("ecr", region_name="us-east-1")