SSM: Fix bad state caused by invalid PutParameter request (#6484)

getmoto · Jul 7, 2023 · 89f2a3c · 89f2a3c
1 parent 47bca5b
commit 89f2a3c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/moto/ssm/models.py b/moto/ssm/models.py
@@ -2062,7 +2062,11 @@ def put_parameter(
                     "formed as a mix of letters, numbers and the following 3 symbols .-_"
                 )
             raise ValidationException(invalid_prefix_error)
-        if not parameter_type and not overwrite and not self._parameters[name]:
+        if (
+            not parameter_type
+            and not overwrite
+            and not (name in self._parameters and self._parameters[name])
+        ):
             raise ValidationException(
                 "A parameter type is required when you create a parameter."
             )

diff --git a/tests/test_ssm/test_ssm_boto3.py b/tests/test_ssm/test_ssm_boto3.py
@@ -448,6 +448,9 @@ def test_put_parameter_no_type():
         == "A parameter type is required when you create a parameter."
     )
 
+    # Ensure backend state is consistent
+    assert client.describe_parameters()
+
 
 @mock_ssm
 def test_update_parameter():