Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for instance public ip not being cleared on eip disassociation #1149

Merged
merged 1 commit into from
Sep 16, 2017

Conversation

nuwang
Copy link
Contributor

@nuwang nuwang commented Sep 16, 2017

This PR fixes the following issues

  1. When disassociating an EIP, the instance's public ip address does not get cleared
  2. Cleans up a duplicated assignment of instance public ip during EIP association
  3. Adds tests to enforce these

@coveralls
Copy link

coveralls commented Sep 16, 2017

Coverage Status

Coverage decreased (-0.001%) to 93.592% when pulling 0953ddd on gvlproject:fix_disassociate_address into b3ce255 on spulec:master.

@JackDanger
Copy link
Collaborator

Wonderful!

@JackDanger JackDanger merged commit a7049ac into getmoto:master Sep 16, 2017
@JackDanger
Copy link
Collaborator

Released as part of Moto 1.1.10

@nuwang nuwang deleted the fix_disassociate_address branch September 17, 2017 05:50
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These has been merged into moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These has been merged into moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These has been merged into moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These has been merged into moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These have been merged into Moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Sep 17, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These have been merged into Moto 1.1.10
nuwang added a commit to CloudVE/cloudbridge that referenced this pull request Nov 25, 2017
The following PRs fix various moto issues:
- getmoto/moto#1140
- getmoto/moto#1146
- getmoto/moto#1148
- getmoto/moto#1149
- getmoto/moto#1150
- getmoto/moto#1152

These have been merged into Moto 1.1.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants