Fix botocore/boto3 dependency version mismatch #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.2%) to 92.413% when pulling aa5e4a5d2f7f3b008a06bdbb2c0bb5074d0700bf on meneal:fix/mismatch into e8c65d3 on spulec:master. |
shawnzhu
reviewed
Aug 29, 2018
setup.py
Outdated
| @@ -8,7 +8,7 @@ | |||
| install_requires = [ | |||
| "Jinja2>=2.7.3", | |||
| "boto>=2.36.0", | |||
| "boto3>=1.6.16", | |||
| "boto3==1.7.84", | |||
There was a problem hiding this comment.
it will force the tested app installs [email protected] which may be unexpected.
What about "boto3>=1.6.16,<1.8",?
Pinning boto3 to this version would remove the mismatch between boto3 and the botocore dependency in setup.py. Closes getmoto#1800
|
@tomelliff comments addressed. |
shawnzhu
approved these changes
Aug 30, 2018
meneal
changed the title
justineyster
approved these changes
Aug 30, 2018
|
🔥 🔥 🔥 |
|
please make this merge.... I'm working on aws and I can't just use a previous version of boto. This breaks my tests to the point where I have to manually mock the resources myself, which defeats the purpose of using this lib. Hopefully you can get this pulled in asap so we can get over this problem. |
|
Joining @joshua-alday , this is needed ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning boto3 to this version would remove the mismatch between
boto3 and the botocore dependency in setup.py.
Closes #1800